make sure that ACK frames are bundled with data #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
==========================================
- Coverage 86.30% 86.28% -0.03%
==========================================
Files 122 122
Lines 9718 9744 +26
==========================================
+ Hits 8387 8407 +20
- Misses 990 996 +6
Partials 341 341
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
bundle-acks
branch
2 times, most recently
from
a323163
to
c6c0054
Compare
lucas-clemente
approved these changes
May 15, 2020
| @@ -22,25 +22,26 @@ func newReceivedPacketHistory() *receivedPacketHistory { | |||
| } | |||
|
|
|||
| // ReceivedPacket registers a packet with PacketNumber p and updates the ranges | |||
| func (h *receivedPacketHistory) ReceivedPacket(p protocol.PacketNumber) { | |||
| func (h *receivedPacketHistory) ReceivedPacket(p protocol.PacketNumber) bool /* is a new packet (and not a duplicate / delayed packet) */ { | |||
There was a problem hiding this comment.
Maybe return an enum instead? Bools as return values can be hard to understand when the function name doesn't make it clear.
There was a problem hiding this comment.
How would that work? There are no enums in Go. Do you want to define a type alias for a bool?
type isNewType bool
const (
isNew isNewType = true
isNotNew isNewType = false
)| @@ -117,15 +117,15 @@ func (h *receivedPacketHandler) GetAckFrame(encLevel protocol.EncryptionLevel) * | |||
| switch encLevel { | |||
| case protocol.EncryptionInitial: | |||
| if h.initialPackets != nil { | |||
| ack = h.initialPackets.GetAckFrame() | |||
| ack = h.initialPackets.GetAckFrame(true) | |||
There was a problem hiding this comment.
Idem, this is quite hard to read without context :)
marten-seemann
force-pushed
the
bundle-acks
branch
from
c6c0054
to
b91874a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2539.