Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a send stream test that randomly acknowledges and loses data #2535

Merged
merged 1 commit into from
May 13, 2020

Conversation

marten-seemann
Copy link
Member

In an attempt to find the race condition of #2533 I wrote this test. Turns out that the race condition is not caused by handling of lost frames in the stream.

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #2535 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2535      +/-   ##
==========================================
+ Coverage   86.12%   86.16%   +0.03%     
==========================================
  Files         122      122              
  Lines        9542     9542              
==========================================
+ Hits         8218     8221       +3     
+ Misses        985      983       -2     
+ Partials      339      338       -1     
Impacted Files Coverage Δ
send_stream.go 93.36% <0.00%> (+0.37%) ⬆️
server.go 83.59% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7f9f7...d1c6d80. Read the comment docs.

@marten-seemann marten-seemann merged commit e569a3d into master May 13, 2020
@marten-seemann marten-seemann deleted the send-stream-stress-test branch May 13, 2020 14:38
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants