Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immediately remove reset tokens when retiring a connection ID #2897

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

marten-seemann
Copy link
Member

Otherwise, packet reordering could result in a stateless reset and an unwanted termination of the session.

It will probably be wise to cut another patch release after merging this PR.

@marten-seemann marten-seemann force-pushed the immediately-delete-stateless-reset-tokens branch from df5e725 to 05066ae Compare November 22, 2020 03:21
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #2897 (05066ae) into master (69158cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2897      +/-   ##
==========================================
+ Coverage   85.77%   85.79%   +0.01%     
==========================================
  Files         133      133              
  Lines        9187     9175      -12     
==========================================
- Hits         7880     7871       -9     
+ Misses        959      956       -3     
  Partials      348      348              
Impacted Files Coverage Δ
internal/flowcontrol/base_flow_controller.go 100.00% <ø> (ø)
packet_handler_map.go 73.81% <ø> (+0.79%) ⬆️
session.go 77.27% <ø> (ø)
conn_id_manager.go 93.48% <100.00%> (-0.07%) ⬇️
internal/flowcontrol/connection_flow_controller.go 100.00% <100.00%> (ø)
internal/flowcontrol/stream_flow_controller.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1956f...05066ae. Read the comment docs.

@marten-seemann marten-seemann merged commit afe287e into master Dec 4, 2020
@marten-seemann marten-seemann deleted the immediately-delete-stateless-reset-tokens branch December 6, 2020 02:51
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants