cross compile quic-go for all platforms / architectures #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
cross-compile-test
branch
from
e9ea0cc
to
f400ceb
Compare
mvdan
reviewed
Nov 20, 2020
.github/workflows/cross-compile.yml
Outdated
| crosscompile: | ||
| strategy: | ||
| matrix: | ||
| go: [ "1.14", "1.15" ] |
There was a problem hiding this comment.
beware that this is 1.14.0, not the latest 1.14.x. You should use [ "1.14.x", "1.15.x" ].
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 133 133
Lines 9187 9187
=======================================
Hits 7880 7880
Misses 959 959
Partials 348 348 Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Dec 3, 2020
marten-seemann
force-pushed
the
cross-compile-test
branch
from
f400ceb
to
db5e6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cross-compilation GitHub Actions test. Thanks to @mvdan for his input on the script!
The problem here is that the test runs for ~10 minutes. We might want to limit this to PRs and commits to master.