From 939a50916625dfe03300c14fd7d32e5bbb3bb0f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luca=20B=C3=B6sch?= <luca.boesch@bfh.ch>
Date: Mon, 4 May 2020 00:22:39 +0200
Subject: [PATCH] Removing margin-right in favour of Bootstrap classes.

---
 classes/question/bank/question_bank_filter.php | 2 +-
 renderer.php                                   | 4 ++--
 styles.css                                     | 5 -----
 3 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/classes/question/bank/question_bank_filter.php b/classes/question/bank/question_bank_filter.php
index 403be240..98c63e87 100644
--- a/classes/question/bank/question_bank_filter.php
+++ b/classes/question/bank/question_bank_filter.php
@@ -353,7 +353,7 @@ public function __construct($name, $label, $advanced, $field, $disableelements,
      */
     public function setup_form_in_group(&$mform, &$group) {
         $disableelements = implode(',', $this->disableelements);
-        $linktoggle = \html_writer::tag('a', $this->_label, ['href' => '#', 'class' => 'link-toggle mb-1',
+        $linktoggle = \html_writer::tag('a', $this->_label, ['href' => '#', 'class' => 'link-toggle mr-1 mb-1',
                 'title' => $this->helptext, 'for' => 'id_' . $this->_name, 'data-disableelements' => $disableelements,
                 'role' => 'button']);
         $element = $mform->createElement('checkbox', $this->_name, null, $linktoggle, ['class' => 'toggle']);
diff --git a/renderer.php b/renderer.php
index 1e4569db..35275205 100644
--- a/renderer.php
+++ b/renderer.php
@@ -1258,7 +1258,7 @@ public function render_control_buttons($catcontext, $hasquestionincategory, $add
             'returnurl' => $this->page->url]);
         if ($hasquestionincategory) {
             $params = [
-                'class' => 'btn btn-primary form-submit',
+                'class' => 'btn btn-primary form-submit mr-1 mb-1',
                 'type' => 'submit',
                 'name' => 'startquiz',
                 'formmethod' => 'get',
@@ -1293,7 +1293,7 @@ public function render_control_buttons($catcontext, $hasquestionincategory, $add
 
         if ($caneditall) {
             $output .= html_writer::empty_tag('input', [
-                'class' => 'btn btn-secondary',
+                'class' => 'btn btn-secondary mr-1 mb-1',
                 'type' => 'submit',
                 'name' => 'deleteselected',
                 'formaction' => $deleteurl,
diff --git a/styles.css b/styles.css
index 6e4e4b56..ac7c252a 100644
--- a/styles.css
+++ b/styles.css
@@ -59,7 +59,6 @@
     border-bottom: 2px solid darkgray;
     border-radius: 4px;
     display: inline-block;
-    margin-right: 5px;
     padding: 5px;
     transition: all 0.4s ease;
     text-decoration: none;
@@ -317,10 +316,6 @@
     width: 60px;
 }
 
-.path-mod-studentquiz .modulespecificbuttonscontainer input.btn {
-    margin-right: 5px;
-}
-
 .path-mod-studentquiz #mod_studentquiz_statblock .report_more_url,
 .path-mod-studentquiz #mod_studentquiz_rankingblock .report_more_url {
     text-align: right;