Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not regenerate C headers when the library has not changed #56

Closed
crash-g opened this issue Mar 21, 2020 · 0 comments
Closed

Do not regenerate C headers when the library has not changed #56

crash-g opened this issue Mar 21, 2020 · 0 comments
Labels
D-Easy Easy task, takes about 1hour to be complete enhancement New feature or request help wanted Extra attention is needed

Comments

@crash-g
Copy link

crash-g commented Mar 21, 2020

Currently, C headers are generated every time, regardless of whether project files have changed or not. It would be nice, if possible, to ask Cargo whether this is necessary or not, and only generate them if necessary.
@lu-zero lu-zero added D-Easy Easy task, takes about 1hour to be complete enhancement New feature or request help wanted Extra attention is needed labels Mar 21, 2020
lu-zero added a commit that referenced this issue Mar 21, 2020
@lu-zero
Add fingerprinting support
144b032 
Do not rebuild the header if the library is unchanged.

Done during the first OpenSourceSaturdayOnline.

Fixes #56
@MarcoIeni MarcoIeni mentioned this issue Mar 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-Easy Easy task, takes about 1hour to be complete enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lu-zero @crash-g