Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuild does not generate the shared library in the target/${profile}/ path #43

Closed
dbermond opened this issue Nov 25, 2019 · 6 comments
Closed
Labels
D-Hard A task that takes serveral days to complete enhancement New feature or request help wanted Extra attention is needed

Comments

@dbermond
Copy link

cbuild does not generate the shared library. The shared library is generated only when running cinstall. Tested in rav1e with cargo-c 0.3.1.

Can this be changed so cbuild also generates the shared library?

@lu-zero
Copy link
Owner

lu-zero commented Dec 6, 2019

cbuild generates the shared library, could you provide more information and ls -alR target/*/ ?

@dbermond
Copy link
Author

dbermond commented Dec 6, 2019

I'm using Arch Linux x86_64.
The rust version currently is 1.39.0.
cargo-c is installed on system and currently at version 0.4.0.

Steps used to build rav1e and the C library:

$ git clone https://github.com/xiph/rav1e.git
$ cd rav1e
$ cargo fetch
$ cargo build --release --frozen
$ cargo cbuild --release --prefix='/usr'

After this, the shared library is not generated. Here is the output of ls -alR target/*/.

@lu-zero
Copy link
Owner

lu-zero commented Dec 6, 2019

-rwxr-xr-x 1 user group 22116096 dez  6 20:53 librav1e-bfbf0e656d2012cb.so

It is built but not copied in the main directory. the cargo rustc override story is less than perfect, if you were expecting to have the .so in the target directory.

@dbermond
Copy link
Author

dbermond commented Dec 6, 2019

Yes, I was expecting a clear output of librav1e.so (and the versioned library files) in the main directory, as with cinstall.

Thank you for clarifying this.

If this is a wontfix, fell free to close this issue.

@lu-zero lu-zero added D-Hard A task that takes serveral days to complete enhancement New feature or request help wanted Extra attention is needed labels Dec 7, 2019
@lu-zero lu-zero changed the title cbuild does not generate the shared library cbuild does not generate the shared library in the target/{profile}/ path Dec 7, 2019
@lu-zero lu-zero changed the title cbuild does not generate the shared library in the target/{profile}/ path cbuild does not generate the shared library in the target/${profile}/ path Dec 7, 2019
@lu-zero
Copy link
Owner

lu-zero commented Dec 7, 2019

It is an issue that requires to either fix cargo rustc or to switch to cargo-as-library and make the build time LONG.

@lu-zero
Copy link
Owner

lu-zero commented Mar 21, 2020

Done in 0.6.0 (will be released today)

@lu-zero lu-zero closed this as completed Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Hard A task that takes serveral days to complete enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants