Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a rebuild if non-cargo-significant changes happened #21

Open
lu-zero opened this issue Jul 1, 2019 · 4 comments
Open

Trigger a rebuild if non-cargo-significant changes happened #21

lu-zero opened this issue Jul 1, 2019 · 4 comments
Labels
D-Easy Easy task, takes about 1hour to be complete enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@lu-zero
Copy link
Owner

lu-zero commented Jul 1, 2019

In particular --prefix=/libdir/includedir changes and cbindgen.toml metadata.

@lu-zero lu-zero added enhancement New feature or request help wanted Extra attention is needed D-Easy Easy task, takes about 1hour to be complete labels Jul 1, 2019
@anholt
Copy link

anholt commented Feb 4, 2021

I got bit by two rebuild issues: adding a cbindgen.toml didn't trigger a re-cbindgenning, and setting package.metadata.capi.library name didn't trigger a rebuild of the library, so install failed.

@lu-zero
Copy link
Owner Author

lu-zero commented Feb 4, 2021

should be easy to add both in the hash computation, thank you for reporting.

@Chris--B
Copy link

Chris--B commented Jul 6, 2024

This is still happening and very confusing as a user. I have a workflow that runs clippy, unit tests, and generates this header in one go. As-is, modifying cbindgen.toml does not trigger a rebuild.

As a workaround, I use this to make sure the header is built every time.

rm -fv target/$target/debug/cargo-c-geliad.cache
cargo cbuild

I'm using cargo-c 0.10.2+cargo-0.80.0

@lu-zero
Copy link
Owner Author

lu-zero commented Jul 6, 2024

If you have a timeslice for it, it shouldn't be hard to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-Easy Easy task, takes about 1hour to be complete enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants