Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine instances for ITEOp, SimpleMergeable and Mergeable, rename UnionMergeable1 to SymBranching #214

Merged
merged 8 commits into from
Jun 23, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jun 23, 2024

This pull request:

  • refines instances for ITEOp, SimpleMergeable and Mergeable,
  • renames UnionMergeable1 to SymBranching
  • adds support for unified SimpleMergeable and Mergeable.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 42.48826% with 245 lines in your changes missing coverage. Please review.

Project coverage is 53.32%. Comparing base (d7854bb) to head (0fdbf03).

Files Patch % Lines
...e/Unified/Internal/Class/UnifiedSimpleMergeable.hs 9.46% 151 Missing and 2 partials ⚠️
src/Grisette/Internal/Core/Data/Class/Mergeable.hs 68.09% 53 Missing and 14 partials ⚠️
...isette/Internal/Core/Data/Class/SimpleMergeable.hs 42.85% 12 Missing and 4 partials ⚠️
src/Grisette/Unified/Internal/Class/UnifiedSOrd.hs 0.00% 8 Missing ⚠️
...rc/Grisette/Unified/Internal/Class/UnifiedITEOp.hs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   53.85%   53.32%   -0.53%     
==========================================
  Files          97       96       -1     
  Lines        7675     7828     +153     
  Branches      658      664       +6     
==========================================
+ Hits         4133     4174      +41     
- Misses       2884     2990     +106     
- Partials      658      664       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit e871cf0 into main Jun 23, 2024
18 of 20 checks passed
@lsrcz
Copy link
Owner Author

lsrcz commented Jun 24, 2024

This pull request also works towards #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant