Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgx-lkl-musl code interleaves x86-64 and LKL code #264

Open
davidchisnall opened this issue May 19, 2020 · 4 comments
Open

sgx-lkl-musl code interleaves x86-64 and LKL code #264

davidchisnall opened this issue May 19, 2020 · 4 comments
Labels
area: sgx-lkl Core SGX-LKL functionality enhancement p3 Non-blocking priority
Milestone

Comments

@davidchisnall
Copy link
Contributor

Currently, we have a lot of code paths in musl where we've replaced the normal x86-64 versions with LKL versions. We should eventually revisit these and try to clean them up so that we have a clean separation of upstream vs LKL code.

For example, lsds/sgx-lkl-musl#11 (my fault) replaced the assembly to call the clone syscall. We need to extend the build system to allow musl to select the correct version.

We also need to think carefully about code location. We are likely to have at least x86-64 and AArch64 versions of SGX-LKL in the long term, so we need to handle the differences between the two. We will likely want either lkl/{arch} or {arch}/lkl subdirectories for the LKL-specific code.

@davidchisnall davidchisnall added this to the Milestone 3 milestone May 19, 2020
@prp prp added area: sgx-lkl Core SGX-LKL functionality p3 Non-blocking priority labels May 28, 2020
@bodzhang
Copy link
Contributor

Does the work related to #403 address this issue?

@davidchisnall
Copy link
Contributor Author

No, #403 makes this worse in the short term.

@bodzhang
Copy link
Contributor

Should this issue be added to "Clean up layering" project and bumped to P1?

@davidchisnall
Copy link
Contributor Author

No, it's not a layering violation, it just makes merging changes from upstream musl slightly harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sgx-lkl Core SGX-LKL functionality enhancement p3 Non-blocking priority
Projects
None yet
Development

No branches or pull requests

3 participants