Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test samples in CI #231

Open
letmaik opened this issue May 11, 2020 · 4 comments
Open

Test samples in CI #231

letmaik opened this issue May 11, 2020 · 4 comments
Labels
area: ci/cd Testing and CI enhancement p1 Medium priority
Milestone
Milestone 1

Comments

@letmaik
Copy link
Contributor

letmaik commented May 11, 2020

Samples are not tested in CI and will inevitable break over time if they are not run manually regularly. They should be tested in CI, which may simply be a crash test.
@prp prp removed the area: samples Samples label May 15, 2020
@prp prp added this to the Milestone 1 milestone May 15, 2020
@prp prp added the p1 Medium priority label May 15, 2020
@letmaik
Copy link
Contributor Author

letmaik commented Jun 24, 2020

Example of where this would have helped: #514. We really need to test samples in CI.

@letmaik letmaik mentioned this issue Jun 26, 2020
Merged
@wintersteiger
Copy link

+1. I think this should be p0, it's the first thing prospective users will try!

@davidchisnall davidchisnall added the needs-triage Bug does not yet have a priority assigned label Jul 28, 2020
@SeanTAllen SeanTAllen removed the needs-triage Bug does not yet have a priority assigned label Jul 29, 2020
@bodzhang bodzhang added the needs-triage Bug does not yet have a priority assigned label Aug 17, 2020
@bodzhang
Copy link
Contributor

Enhancing test coverage with the samples will help to discover bugs and stability issues. I think this issue should stay as P1.

@prp
Copy link
Member

prp commented Aug 17, 2020

The samples almost completely overlap with the existing CI tests.

@bodzhang bodzhang removed the needs-triage Bug does not yet have a priority assigned label Aug 21, 2020
@AntonioND AntonioND self-assigned this Sep 8, 2020
This was referenced Sep 15, 2020
Merged
Closed
@AntonioND AntonioND removed their assignment Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ci/cd Testing and CI enhancement p1 Medium priority
Projects
None yet
Milestone
Milestone 1
Development

No branches or pull requests
7 participants
@SeanTAllen @davidchisnall @letmaik @prp @AntonioND @wintersteiger @bodzhang