-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement most icons from https://github.com/Peltoche/lsd/issues/764 #774
Conversation
- PKGBUILD -- Arch Linux package manifests Didn't implement these because I couldn't find a good icon or is just downright impossible to implement - config.\* -- Configuration files - Makefile\* -- Make config - .\*_history -- History files for readline-like - .gdb_history -- GDB debugger history - .lesshst -- `less` history - Kconfig.\* -- Specific kernel config file - Kbuild.\* -- Specific kernel build file - Makefile\* -- Make config - TODO\* -- TODOs - FAQ\* -- FAQ - LEGACY\* -- Legacy statement - var/ -- Variable files - mnt/ -- Mounts - proc/ -- Processes - usr/ -- Universal system repository - dev/ -- Device files - boot/ -- Bootloader files - opt/ -- Optional applications - sys/ -- System files - src/ -- source code - tests/ -- Tests for code - test/ -- Test dir - Media/ -- Media dir - rc.conf -- OpenRC config - init.d/ -- OpenRC services - content/ -- Content dir - page/ -- Pages - resources/ -- Resources for programs - static/ -- Static resources - completions/ -- Shell completions - target/ -- Target files - dist/ -- Destination files - dest/ -- Destination files - .local/ -- Local files - local/ -- Local files Signed-off-by: Ari Archer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 44 44
Lines 4332 4332
=======================================
Hits 3755 3755
Misses 577 577
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
("key", "\u{e60a}"), // "" | ||
("kt", "\u{e634}"), // "" | ||
("kts", "\u{e634}"), // "" | ||
("ksh", "\u{f489}"), // "" | ||
("ld", "\u{e624}"), // "" | ||
("kts", "\u{e634}"), // "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like kt and kts is repeated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like kt and kts is repeated.
won't it cause another merge conflict if i remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should be fine. The issues is mostly when you merge main into your branch. But don't bother about it now, we've enabled suash merge and I can do that from my end.
@@ -62,7 +62,7 @@ impl ByType { | |||
file: "\u{1f4c4}".into(), | |||
pipe: "\u{1f4e9}".into(), | |||
socket: "\u{1f4ec}".into(), | |||
executable: "\u{1f3d7}".into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stick to the existing one for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stick to the existing one for this.
weird, it was normal before
I've created #779 with fixes on top of your changes. Closing this for now. Thanks for the PR :D |
Didn't implement these because I couldn't find a good icon or is just downright impossible to implement
less
historySigned-off-by: Ari Archer [email protected]
TODO
cargo fmt