Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement most icons from https://github.com/Peltoche/lsd/issues/764 #774

Closed
wants to merge 2 commits into from
Closed

Implement most icons from https://github.com/Peltoche/lsd/issues/764 #774

wants to merge 2 commits into from

Conversation

TruncatedDinoSour
Copy link
Contributor

  • PKGBUILD -- Arch Linux package manifests

Didn't implement these because I couldn't find a good icon or is just downright impossible to implement

  • config.* -- Configuration files
  • Makefile* -- Make config
  • .*_history -- History files for readline-like - .gdb_history -- GDB debugger history - .lesshst -- less history
  • Kconfig.* -- Specific kernel config file
  • Kbuild.* -- Specific kernel build file
  • Makefile* -- Make config
  • TODO* -- TODOs - FAQ* -- FAQ - LEGACY* -- Legacy statement
  • var/ -- Variable files
  • mnt/ -- Mounts
  • proc/ -- Processes
  • usr/ -- Universal system repository
  • dev/ -- Device files
  • boot/ -- Bootloader files
  • opt/ -- Optional applications
  • sys/ -- System files
  • src/ -- source code
  • tests/ -- Tests for code - test/ -- Test dir
  • Media/ -- Media dir
  • rc.conf -- OpenRC config - init.d/ -- OpenRC services
  • content/ -- Content dir
  • page/ -- Pages
  • resources/ -- Resources for programs - static/ -- Static resources
  • completions/ -- Shell completions
  • target/ -- Target files
  • dist/ -- Destination files - dest/ -- Destination files
  • .local/ -- Local files - local/ -- Local files

Signed-off-by: Ari Archer [email protected]


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

- PKGBUILD -- Arch Linux package manifests

Didn't implement these because I couldn't find a good icon
or is just downright impossible to implement

- config.\* -- Configuration files
- Makefile\* -- Make config
- .\*_history -- History files for readline-like
    - .gdb_history -- GDB debugger history
    - .lesshst -- `less` history
- Kconfig.\* -- Specific kernel config file
- Kbuild.\* -- Specific kernel build file
- Makefile\* -- Make config
- TODO\* -- TODOs
    - FAQ\* -- FAQ
    - LEGACY\* -- Legacy statement
- var/ -- Variable files
- mnt/ -- Mounts
- proc/ -- Processes
- usr/ -- Universal system repository
- dev/ -- Device files
- boot/ -- Bootloader files
- opt/ -- Optional applications
- sys/ -- System files
- src/ -- source code
- tests/ -- Tests for code
    - test/ -- Test dir
- Media/ -- Media dir
- rc.conf -- OpenRC config
    - init.d/ -- OpenRC services
- content/ -- Content dir
- page/ -- Pages
- resources/ -- Resources for programs
    - static/ -- Static resources
- completions/ -- Shell completions
- target/ -- Target files
- dist/ -- Destination files
    - dest/ -- Destination files
- .local/ -- Local files
    - local/ -- Local files

Signed-off-by: Ari Archer <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #774 (d664786) into master (f5ee0a2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   86.68%   86.68%           
=======================================
  Files          44       44           
  Lines        4332     4332           
=======================================
  Hits         3755     3755           
  Misses        577      577           
Impacted Files Coverage Δ
src/theme/icon.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

("key", "\u{e60a}"), // ""
("kt", "\u{e634}"), // ""
("kts", "\u{e634}"), // ""
("ksh", "\u{f489}"), // ""
("ld", "\u{e624}"), // ""
("kts", "\u{e634}"), // ""
Copy link
Member

@meain meain Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like kt and kts is repeated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like kt and kts is repeated.

won't it cause another merge conflict if i remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should be fine. The issues is mostly when you merge main into your branch. But don't bother about it now, we've enabled suash merge and I can do that from my end.

@TruncatedDinoSour TruncatedDinoSour requested review from meain and removed request for Peltoche November 19, 2022 13:08
@@ -62,7 +62,7 @@ impl ByType {
file: "\u{1f4c4}".into(),
pipe: "\u{1f4e9}".into(),
socket: "\u{1f4ec}".into(),
executable: "\u{1f3d7}".into(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to the existing one for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to the existing one for this.

weird, it was normal before

@meain
Copy link
Member

meain commented Nov 23, 2022

I've created #779 with fixes on top of your changes. Closing this for now. Thanks for the PR :D

@meain meain closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants