You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This program has a severe performance problem on windows when the number of files to read is large (30+), it blocks almost 100ms untill it starts to render with Core::display, I dug on the issue and its located on the Win32 call to GetEffectiveRightsFromAclW, I don't know why is so expensive.
Proposed solutions:
Figure out why that function call is so expensive (maybe we can't solve it)
Be more inaccurate on windows about the permissions of the user and group (since its not very relevant on windows systems), for example the libcxx of llvm obtains the permissions of a file assuming its read only and then just checking if the property FILE_ATTRIBUTE_READONLY is set or not, assume that everything is executable and similar "inaccurate stuff"
Change the creation of the Meta struct to only retrieve the owner/group permissions if its really needed to display
Hope this helps
The text was updated successfully, but these errors were encountered:
hi @cdecompilador, thanks for the analysis, we have an issue discussing performance on windows before, I am closing this one and we can discuss it there
This program has a severe performance problem on windows when the number of files to read is large (30+), it blocks almost 100ms untill it starts to render with
Core::display
, I dug on the issue and its located on the Win32 call toGetEffectiveRightsFromAclW
, I don't know why is so expensive.Proposed solutions:
Meta
struct to only retrieve the owner/group permissions if its really needed to displayHope this helps
The text was updated successfully, but these errors were encountered: