Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to check default theme file and load it if existed #709

Open
zwpaper opened this issue Jul 29, 2022 · 0 comments
Open

ability to check default theme file and load it if existed #709

zwpaper opened this issue Jul 29, 2022 · 0 comments

Comments

@zwpaper
Copy link
Member

zwpaper commented Jul 29, 2022

How about for icons theme, we explicitly call it overrides and keep the theme one with existing functionality. I am not sure if that is the best approach though.

For folks without patched fonts, unicode is an option to get some icons without much hurdle.


One other option that I strongly prefer is something different. We don't let users specify a file, instead if a file called colors.yaml is preset in $XDG_CONFIG_HOME/lsd, we load colors from there and if a file called icons.yaml is present, we load icons from there. It feels much simpler. We can support specifying themes in both ways for color for some time with a deprecation message on the old way while people switch. The current way of specifying a file path seems a bit clunky overall.

Originally posted by @meain in #707 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant