Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the daed code(NoLscolors) for testing #552

Open
zwpaper opened this issue Sep 9, 2021 · 0 comments
Open

remove the daed code(NoLscolors) for testing #552

zwpaper opened this issue Sep 9, 2021 · 0 comments

Comments

@zwpaper
Copy link
Member

zwpaper commented Sep 9, 2021

after #452 merged, the themeOption::NoLscolor is only used for testing, it is warned as dead code in Clippy, we currently mark it allowed, and it should be improved to drop the dead code.

maybe we could:

  1. add a new LSCOLORS for testing
  2. use a different way for color testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zwpaper