-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling default/none values in theme config #549
Comments
I have not been able to take a look at the PR, but being able to skip some would be necessary for it to be useful IMO. My idea is that users should be able to ignore some options and that would use the default color, but at the same time they should be able to specify something like |
Yes, it is necessary! but the theme feature could work functionally without it, so that people could use the feature much earlier if we merge #452 first. because
|
Makes sense ;). Let me go through #452 over the weekend. |
After #452 merged, lsd now supports yaml-based theme configuration.
but a completed configuration file is needed, if any items are missed, the whole theme would fall back to the default one.
we should update the theme struct to
Option
and allow some items missed.we should discuss that the missed fields should indicate which one color:
The text was updated successfully, but these errors were encountered: