Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should use a more elegant way to handle get_light_theme_colour_map and avoid the #[allow(dead_code)] #506

Closed
zwpaper opened this issue Mar 25, 2021 · 1 comment · Fixed by #452
Closed

should use a more elegant way to handle get_light_theme_colour_map and avoid the #[allow(dead_code)] #506

zwpaper opened this issue Mar 25, 2021 · 1 comment · Fixed by #452
Labels
kind/enhancement Enhancement on current feature

Comments

@zwpaper
Copy link
Member

zwpaper commented Mar 25, 2021

as described there #489 (comment),

we can make the color that is returned an Option and make this return None? I think we can take that up in another PR as well. This would let us remove the #[allow(dead_code)] above the struct definition.

we should handle get_light_theme_colour_map in a more elegant way

https://github.com/Peltoche/lsd/blob/734d4007238279fc22b63fc845e33e1f89f199a7/src/color.rs#L188
@zwpaper zwpaper added the kind/enhancement Enhancement on current feature label Mar 25, 2021
@zwpaper zwpaper mentioned this issue Mar 25, 2021
Merged
3 tasks
@zwpaper
Copy link
Member Author

zwpaper commented Jul 8, 2021

this could be fixed by #452

@zwpaper zwpaper linked a pull request Jul 8, 2021 that will close this issue
yaml based theme support #452
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement on current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

yaml based theme support zwpaper/lsd
1 participant
@zwpaper