Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to set a theme color to the default foreground color #896

Open
Nemo157 opened this issue Sep 7, 2023 · 3 comments · May be fixed by #1102
Open

No way to set a theme color to the default foreground color #896

Nemo157 opened this issue Sep 7, 2023 · 3 comments · May be fixed by #1102
Labels
kind/enhancement Enhancement on current feature

Comments

@Nemo157
Copy link

Nemo157 commented Sep 7, 2023

crossterm::style::Color only supports the 8-bit ansi color codes, there is no way to make it emit code 39 which uses the default foreground color (which can be distinct from the normal and bright variants of both white and black).

As a workaround, adding support for parsing a string like reset to Color::Reset should give a similar result.
@Destroy666x
Copy link

Yes, please add support for Reset as it currently does not work: https://docs.rs/crossterm/latest/crossterm/style/enum.Color.html#variant.Reset

@zwpaper
Copy link
Member

zwpaper commented Sep 20, 2023

/kind enhancement

@muniu-bot muniu-bot bot added the kind/enhancement Enhancement on current feature label Sep 20, 2023
@Destroy666x Destroy666x mentioned this issue Sep 20, 2023
Closed
@Destroy666x
Copy link

Fixing above would likely be the easiest way to fix this from what I see, as this just uses the deserialization. Otherwise a workaround is needed.

@Destroy666x Destroy666x linked a pull request Oct 24, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement on current feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump crossterm to 0.28.0 Destroy666x/lsd
3 participants
@Nemo157 @Destroy666x @zwpaper