-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: icons.yaml
does not seem to override icons
#1082
Comments
@hawkw FYI, this appears to be fixed as of version 1.1.5. Here are some custom overrides in my |
The custom icons are only applied when the icon theme is Lines 16 to 26 in 82124fd
This should ideally be reflected in the documentation, I spent quite a while trying to figure out why my icons were not working. |
@hxlnt , I am not able to reproduce your setup with the same version. Could you please share your |
@nilp0inter Sure, though the characters won't render correctly here, as they require a Nerdfont. I've also included my config.yaml. config.yaml:
icons.yaml
|
@hxlnt Thanks! I was able to identify the issue. It turned out that I was trying to override the |
Version
version
What OS are you seeing the problem on?
Linux
installation
From Nixpkgs
term
ls-colors
What happened?
I have an
icons.yaml
file in$HOME/config/lsd/icons.yaml
. Theicons.theme
key in$HOME/.config/lsd/config.yaml
is set to "unicode", andicons.when
is set to "auto". However, my specified file type icons inicons.yaml
do not seem to override the defaults.For example:
Note that the overridden directory, block device, char device, and file icons in
icons.yaml
are not used.What expected?
I would have expected the overridden icons to be used, as described in the README here.
What else?
It seems like the documentation on setting a custom icon theme in the README may no longer describe
lsd
's actual behavior? Looking atlsd/src/theme.rs
, it looks like theTheme
struct now attempts to parse an icon theme, color theme, and Git symbols from the same file:lsd/src/theme.rs
Lines 18 to 26 in 9b310da
lsd/src/theme.rs
Lines 39 to 83 in 9b310da
I'd be happy to open a PR to either update the documentation or fix the implementation so that it does what the documentation says! However, before doing that, it would be great to hear from the maintainers regarding what the intended behavior here is. Is the icon theme still supposed to be parsed from
$XDG_CONFIG_HOME/lsd/icons.yaml
as described in the README, or is the apparent behavior of parsing both the icons and color theme from the same YAML file correct? If the current behavior is intended, how is the new theme file supposed to be used --- where should it be located, and how do I pointlsd
at it?The text was updated successfully, but these errors were encountered: