Links need to be URI encoded #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Didn't have such a use case so far. Your fix on that isn't sufficient and has some side effects. Fixed it by don't decode the href and absHref attributes, but only the labels. Fixed in release 0.10 |
lrsjng
added a commit
that referenced
this pull request
Jul 24, 2011
… instructions) * fixed tree fade-in-fade-out effect for small displays ([issue #6](http://github.com/lrsjng/h5ai/issues/6)) * added custom scrollbar to tree ([issue #6](http://github.com/lrsjng/h5ai/issues/6)) * fixed broken links caused by URI encoding/decoding ([issue #9](http://github.com/lrsjng/h5ai/issues/9)) * added "empty" to localization (hope Google Translate did a good job here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First off, I love this project.
My first test happened to have some weirdly named files: "10%20Another%20Bloody%20Election-192.mp3" which was being (correctly) rendered by apache as "10%2520Another%2520Bloody%2520Election-192.mp3". H5ai was decoding the URI as it read the apache html (which puts it back to "10%20Another%20Bloody%20Election-192.mp3") but when writing it out it wasn't re-encoding it. This ended up losing one level of encoding and the link became incorrect and unreachable (apache was looking for "10 Another Bloody Election-192.mp3" in the directory which doesn't exist).
My change adds URI encoding to the output so that strange files like the above work just fine.
-David