Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down interface #5

Open
yoshuawuyts opened this issue Mar 26, 2020 · 1 comment
Open

Trim down interface #5

yoshuawuyts opened this issue Mar 26, 2020 · 1 comment

Comments

@yoshuawuyts
Copy link
Collaborator

I've been using femme for a while now, and initializing it always requires copying over some boilerplate. I wish we could streamline this slightly:

femme::info()?; // start femme with info log level
femme::trace()?; // start femme with trace level

In addition to that, something that env-logger does well is provide a way to filter messages. In reality these methods should be be a constructor for a Logger struct that can be further configured.

This would also allow us to trim down the submodules we have. When piping we should always print out ndjson. When printing to stdout we should use the pretty printer.

The "simple" printer becomes a bit of a strange one, but perhaps we don't need it per-se? I'm unsure really. Thoughts would be welcome here. Thanks!

@Fishrock123
Copy link
Contributor

This issue seems like it was addressed in aa1fd83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants