Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action failing due twemoji CDN broken #1346

Closed
fbuireu opened this issue Jan 12, 2023 Discussed in #1345 · 3 comments · Fixed by #1355
Closed

Action failing due twemoji CDN broken #1346

fbuireu opened this issue Jan 12, 2023 Discussed in #1345 · 3 comments · Fixed by #1355

Comments

@fbuireu
Copy link

fbuireu commented Jan 12, 2023

Discussed in #1345

Originally posted by fbuireu January 12, 2023
It seems that since 3 days ago the CND of twemoji is failing. According to the stack trace of the issue:

AxiosError: getaddrinfo ENOTFOUND twemoji.maxcdn.com
    at Function.AxiosError.from (file:///metrics/node_modules/axios/lib/core/AxiosError.js:89:14)
    at RedirectableRequest.handleRequestError (file:///metrics/node_modules/axios/lib/adapters/http.js:516:25)
    at RedirectableRequest.emit (node:events:390:28)
    at ClientRequest.eventHandlers.<computed> (/metrics/node_modules/follow-redirects/index.js:14:24)
    at ClientRequest.emit (node:events:390:28)
    at TLSSocket.socketErrorListener (node:_http_client:442:9)
    at TLSSocket.emit (node:events:390:28)
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {

Also by accessing (or trying) https://twemoji.maxcdn.com/

twemoji guys seem to be discussing a workaround in this GitHub thread, which basically consists of a user-land approach:

twemoji.parse(
  document.body,
  { base: 'https://cdn.jsdelivr.net/gh/twitter/[email protected]/assets/' }
)
```</div>
@lowlighter
Copy link
Owner

Hi !

Thanks a lot for reporting this issue !

Seems like the user-land approach is a temporary measure, but it'd be better to wait for a new release since it seems they already patched the code for it.

Actually it seems they made a fork of it from what I've read in twitter/twemoji#580 (comment) (don't know the details but the original maintainers seems to have been either laid off or quitted the company 😅 ) so the resolution for this issue might just to switch the dependency to this new fork

@fbuireu
Copy link
Author

fbuireu commented Jan 13, 2023

Indeed! More workarounds appeared in the meantime.

Are you planning to switch dependencies to bypass the breaking action anytime soon?

Thanks for your work 😄

@lowlighter
Copy link
Owner

Yes I'll switch to the maintained fork and it should be fixed in next release 👍 !

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants