[sival,tests] Fix old TODOs and other enhancements #25362
+1,090
−1,313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a TODO relating to the cpu crash dump. Enhance the clkmgr_off_peri and clkmgr_off_trans tests to check the fault PC, which was a stretch goal. Change the testplan to include this extra check. Signed-off-by: Guillermo Maturana <[email protected]>
Signed-off-by: Guillermo Maturana <[email protected]>
matutem
added
Component:ChipLevelTest
Issue lowRISC#20747 relates to csrng generating too many interrupts, causing the all_irqs test to fail due to unexpected interrupts. This required the test to have additional code to work around this issue. Once lowRISC#20747 was fixed these work-arounds are not needed. Signed-off-by: Guillermo Maturana <[email protected]>
Remove the workaround for lowRISC#20798 from the test pwrmgr_random_sleep_all_wake_ups, since the issue was fixed. Also remove the pwrmgr_sleep_wake_5_bug test used to reproduce the bug since it is of no use. Signed-off-by: Guillermo Maturana <[email protected]>
Signed-off-by: Guillermo Maturana <[email protected]>
These comments only apply to the SimDV platform, so they don't belong in the C code. Signed-off-by: Guillermo Maturana <[email protected]>
matutem
force-pushed
the
test_enhancements
branch
from
9b1fbf3
to
c9c96bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few independent commits: