[csrng] Extend coverage definition for glen #23847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves lowRISC#18350. Signed-off-by: Pirmin Vogel <[email protected]>
The NIST SP 800-90A spec uses the term `max_number_of_bits_per_request` whereas our spec was using `max_number_of_bit_per_request`. It's better to align terminology to simplify browsing the specs and comparing them. Signed-off-by: Pirmin Vogel <[email protected]>
vogelpi
requested review from
eshapira,
andreaskurth and
h-filali
and removed request for
a team and
eshapira
rswarbrick
approved these changes
Jul 2, 2024
The main motivation was to increase readability of the crosses :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the RTL doesn't handle Generate commands with a glen equal 0 (generate NO randomness) correctly. But this behavior documented already. We could correct the design to signal a error status response instead, but this really isn't a priority as a Generate command that shouldn't generate entropy is a corner case and even the NIST spec isn't fully clear what should happen here. See #23846 for details.
Thus, this PR simply takes care of extending the coverage definition for the glen coverpoint as outlined in #18350. This resolves #18350.