Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[edn] Improve FSM coverage #23092

Merged
merged 3 commits into from
May 14, 2024
Merged

[edn] Improve FSM coverage #23092

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d8c6e0
[edn/rtl] Make Error main SM state terminal again
vogelpi May 13, 2024
5c56c7f
[edn/dv] Fix FSM coverage holes
vogelpi May 13, 2024
4453fba
[edn/rtl] Fix Verilator lint errors and warnings
vogelpi May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hw/ip/edn/rtl/edn_main_sm.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ module edn_main_sm import edn_pkg::*; #(
endcase

if (local_escalate_i || csrng_ack_err_i) begin
state_d = local_escalate_i ? Error : RejectCsrngEntropy;
// Either move into RejectCsrngEntropy or Error but don't move out of Error as it's terminal.
state_d = local_escalate_i ? Error :
state_q == Error ? Error : RejectCsrngEntropy;
Comment on lines +183 to +185
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you caught that.

// Tie off outputs, except for main_sm_err_o and reject_csrng_entropy_o.
boot_wr_ins_cmd_o = 1'b0;
boot_wr_gen_cmd_o = 1'b0;
Expand Down