[cherry-pick] #22772, #22837, and #22810 to earlgrey_es_sival branch
#22907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
approved these changes
Apr 30, 2024
moidx
approved these changes
May 1, 2024
Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 80c8a02)
Names were previously represented as maps but this is problematic for two reasons: - order is not preserved, - it cannot represente multi-valued RDNs (although they are are). This commit changes the representation to an array of maps so that it maps cleanly to the ASN1 representation (sequence of sets). In particular the order in the array preserved while the order in the map/set is arbitrary (this matches the expected X501 behaviour). This makes the hjson a little bit more ugly but it's not too terrible. One issue that arises from this change is that although it is very easy to modify the builder to handle multi-valued RDNs, the openssl parser cannot reconstruct them because the openssl-sys binding misses a function (see FIXME in the code). Since multi-valued RDNs are rare and not used in our codebase presently, we simply assume single-valued RDNs are the moment. Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 11e5cf5)
The main purpose of this commit is to update the openssl crate version to a newer version. However, repinning breaks sw/host/tests/crypto because they depend on specific crates and crate features that are not explicitely set in Cargo.toml, hence this commit also corrects that. Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 3a8460d)
The newer version of the openssl crate provides a safe wrapper to get a directory name out of a general name. Signed-off-by: Amaury Pouly <[email protected]> (cherry picked from commit 16a55f0)
This adds a CRC over the host-->device UJSON communication to improve test reliability. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit b561be4)
The LC read test utility was not waiting for the lc_ctrl to be ready to receive transactions before reading the LC state. This increases the reliability of this utility, and test cases that use it, specifically, the `ft_provision` test case. Additionally, this move the `ft_provision` silicon exec_env to the `teacup` interface (a minor cleanup). Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 8312753)
This refactor's the `personalize_functest` to optimize code reuse. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit fcb75f7)
This refactors the OTBN boot services library, and silicon_creator keymgr driver to enable generating two types attestation keys: 1. DICE keys, that are based on the attestation side of the key ladder, and 2. TPM keys, that are based on the sealing side of the key ladder. This fixes lowRISC#22622. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 641d4e0)
The `otbn_boot_services_functest` must run in the ROM_EXT slot since it manipulates the keygmr state, which normally is done by the ROM_EXT. This partially addresses lowRISC#21706. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 698b5a6)
This refactors the dice lib to optimize code reuse and follow lib asset naming conventions. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit b217f41)
timothytrippel
force-pushed
the
cherry-pick
branch
from
2d6ed3b
to
1b159b1
Compare
pamaury
approved these changes
May 2, 2024
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks several commits from master that enable TPM attestation key generation off of the correct (sealing) side of the keymgr's key ladder.