[silicon_creator] refactor OTBN boot services to enable generating TPM or DICE keys #22810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothytrippel
force-pushed
the
refactor-otbn-boot-svcs
branch
2 times, most recently
from
a79f94d
to
483f34b
Compare
moidx
approved these changes
Apr 26, 2024
timothytrippel
force-pushed
the
refactor-otbn-boot-svcs
branch
from
483f34b
to
1b8ca67
Compare
This refactors the OTBN boot services library, and silicon_creator keymgr driver to enable generating two types attestation keys: 1. DICE keys, that are based on the attestation side of the key ladder, and 2. TPM keys, that are based on the sealing side of the key ladder. This fixes lowRISC#22622. Signed-off-by: Tim Trippel <[email protected]>
The `otbn_boot_services_functest` must run in the ROM_EXT slot since it manipulates the keygmr state, which normally is done by the ROM_EXT. This partially addresses lowRISC#21706. Signed-off-by: Tim Trippel <[email protected]>
This refactors the dice lib to optimize code reuse and follow lib asset naming conventions. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
refactor-otbn-boot-svcs
branch
from
1b8ca67
to
b9a2ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #22622 to enable generating TPM attestation keys off of the keymgr sealing side and DICE attestation keys off of the keymgr attestation side.
Additionally, this cleans up the DICE lib to reduce code size and align naming conventions.