[ipgen,clkmgr] Create ipgen files #21202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matutem
force-pushed
the
ipgen_clkmgr
branch
9 times, most recently
from
b3acef9
to
53e24a4
Compare
17 tasks
Part of lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
This is a straight copy with no changes to the files. Part of lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
In ipgen template files are at the corresponding directory where their generated file will reside. There is no use for files in ip_templates that will end up being generated. The clkmgr.cfg.example.hjson file is obsolete and misleading. The clkmgr_sec_cm_testplan.hjson needs to be removed from templates or it will overwrite the real top-specific testplan at ip_autogen. Part of lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
The files are almost identical to the previous ones, except they use
${topname} instead of a specific name and consecutive '#' are escaped
so they are not considered md comments. This escape replaces things like
`###` by `${"###"}`.
Adjust some relative paths to account for the change in the file locations.
Use {self_dir} to simplify some paths: it points to the location of the hjson
file used to process the contents of a given file.
Part of lowRISC#8440
Signed-off-by: Guillermo Maturana <[email protected]>
The template core files use instance_vlnv, and declare a virtual target. Other core files depending on the template cores depend on the corresponding virtual target instead. Part of rstmgr lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
The custom template generation used class objects, ipgen uses dictionaries instead. Make minor changes in the templates causing no functional change. Part of rstmgr lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
Template files are only intended for code generation, so it makes no sense to use them to build targets. - Add clkmgr in hw/ip_templates/BUILD all_files - Add exclusion for clkmgr_regs in azure-pipelines.yml Part of lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
The legacy flow and files is preserved. Add FUSESOC_IGNORE in hw/ip_templates/clkmgr: it can be removed once the clkmgr change to ipgen is complete. Part of lowRISC#8440 Signed-off-by: Guillermo Maturana <[email protected]>
|
The one failure is completely unrelated to this change. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the clkmgr generated files using ipgen, but keep using the legacy flow for now. This is so the full transition is broken into two stages for ease of reviewing. A subsequent change will complete the transition to ipgen and remove the legacy files.
Just like previous IP transitions to ipgen, most of legacy files are simply copied to hw/ip_templates/clkmgr, but the following changes are noteworthy:
instance_vlnvand declare a virtual name for template code, and other clkmgr core files to use the virtual name.