Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reggen] Remove the devmode input #20861

Merged
merged 1 commit into from
Jan 18, 2024
Merged

[reggen] Remove the devmode input #20861

merged 1 commit into from
Jan 18, 2024

Conversation

msfschaffner
Copy link
Contributor

As discussed on #10311 we are removing the devmode input signal from the codebase, since it has been decided that this will not be used.

@msfschaffner msfschaffner linked an issue Jan 17, 2024 that may be closed by this pull request
TLUL Error Response and devmode #10311
Closed
@msfschaffner
[reggen] Remove the devmode input
4e8f048 
As discussed on lowRISC#10311 we are removing the devmode input
signal from the codebase, since it has been decided that this
will not be used.

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner marked this pull request as ready for review January 18, 2024 00:19
@msfschaffner msfschaffner requested review from mundaym and a team as code owners January 18, 2024 00:19
@msfschaffner
Copy link
Contributor Author

@arnonsha @meisnere @sha-ron Quick heads-up that when you are switching to master, you have to regenerate your reg-nodes and remove the devmode_i input in your database as well inside the OTP and Flash wrappers.

CC @jdonjdon

@msfschaffner
Copy link
Contributor Author

@vogelpi can you merge this if it looks good to you? Thanks!

rswarbrick
rswarbrick approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible to me. And its gets rid of lots of slightly-copy-paste code. Nice!

vogelpi
vogelpi approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @msfschaffner !

@vogelpi vogelpi merged commit de31bdf into lowRISC:master Jan 18, 2024
32 checks passed
@meisnere
Copy link

meisnere commented Jan 28, 2024 •
edited by msfschaffner
Loading

Hi,
I tried to run on latest DB:
util/regtool.py -r hw/ip/flash_ctrl//data/flash_ctrl.hjson --alias hw/foundry/ip/flash_ctrl/data/prim_asic_flash.hjson -t hw/foundry/ip/prim_asic/rtl/

devmode_i still exists on the created file: flash_ctrl_prim_asic_reg_top

Am I missing something?

@GregAC GregAC mentioned this pull request Feb 23, 2024
Closed
@hcallahan-lowrisc hcallahan-lowrisc mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogelpi vogelpi vogelpi approved these changes

@a-will a-will a-will approved these changes

@rswarbrick rswarbrick rswarbrick approved these changes

@mundaym mundaym Awaiting requested review from mundaym mundaym is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLUL Error Response and devmode
6 participants
@msfschaffner @meisnere @rswarbrick @a-will @vogelpi @opentitan-github-bot