Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sram_ctrl] Minor style cleanup #13677

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[sram_ctrl] Minor style cleanup #13677

merged 2 commits into from
Jul 15, 2022

Conversation

msfschaffner
Copy link
Contributor

Addresses some items on #13676.

@msfschaffner
[sram_ctrl] Minor style cleanup
a0bddc9 
Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner
[sram_ctrl] Update programmers guide
02ef969 
This recommends using a spin wait when requesting a key or initializing
SRAM so that the PC has a more informative value in case the system
hangs and gets reset by the watchdog (this may happen if EDN / CSRNG
have not been initialized properly prior to requesting a new key).

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner self-assigned this Jul 15, 2022
@msfschaffner msfschaffner mentioned this pull request Jul 15, 2022
Closed
6 tasks
a-will
a-will approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@a-will a-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, "should" is more forceful than I was going for, but the important part is the explanation of how it's useful and why it's okay to not do it. Thanks for adding this!

@msfschaffner
Copy link
Contributor Author

msfschaffner commented Jul 15, 2022 •
edited
Loading

Heh, "should" is more forceful than I was going for, but the important part is the explanation of how it's useful and why it's okay to not do it. Thanks for adding this!

Hehe, I chose should because it is somewhere between must and can. I.e., making it a recommendation, but not mandatory.

@msfschaffner msfschaffner merged commit 35ef7fe into lowRISC:master Jul 15, 2022
@msfschaffner msfschaffner deleted the sram-ctrl-opens branch September 30, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-will a-will a-will approved these changes

@GregAC GregAC Awaiting requested review from GregAC

@tjaychen tjaychen Awaiting requested review from tjaychen

Assignees

@msfschaffner msfschaffner

Labels
IP:sram_ctrl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msfschaffner @a-will