Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reggen] Error check for data-intg-passthrough #9544

Open
tjaychen opened this issue Dec 6, 2021 · 4 comments
Open

[reggen] Error check for data-intg-passthrough #9544

tjaychen opened this issue Dec 6, 2021 · 4 comments
Assignees
Labels
Component:RTL Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones Priority:P3 Priority: low Type:FutureRelease Not relevant to currently planned releases/milestones
Milestone

Comments

@tjaychen
Copy link

tjaychen commented Dec 6, 2021

The reggen supports an option called data-intg-passthrough on windowed regions.
If this variable is true, it basically means beyond the window region there is already data integrity, thus the data integrity should not be generated for it in reg_top (the integrity for registers will instead be moved to tlul_adapter_reg).

Having said that, the current scripting does not really handle / check the case if a reg block has multiple windows each with different expectations on data-intg-passthrough. We do not have this case right now, but it would be good to explicitly add an error check to ensure all windows either agree or disagree.

@tjaychen tjaychen self-assigned this Dec 6, 2021
@tjaychen
Copy link
Author

tjaychen commented Dec 6, 2021

@rswarbrick
Copy link
Contributor

And/or teach the generated RTL to handle the mixed case properly. But I agree: that will probably never be used, so it's probably a better idea to mandate one or the other.

@msfschaffner
Copy link
Contributor

Agreed. If we do not want to handle mixed cases in RTL (or don't have the time to implement that), let's just add a check for this.

@tjaychen tjaychen added Component:RTL Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements labels Feb 4, 2022
@tjaychen tjaychen added Type:FutureRelease Not relevant to currently planned releases/milestones and removed Type:Enhancement Feature requests, enhancements labels Apr 15, 2022
@andreaskurth
Copy link
Contributor

andreaskurth commented Feb 21, 2023

Triaged for tlul. Keeping Type:FutureRelease Not relevant to currently planned releases/milestones because we don't make use of this in the current design (as per the issue description).

@msfschaffner msfschaffner added the Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@msfschaffner msfschaffner added this to the Backlog milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL Component:Tooling Issues related to tooling, e.g. tools/scripts for doc, code generation (docgen, reggen), CSR Earlgrey-PROD Triaged Temporary label to triage issues into Earlgrey-PROD Milestones Priority:P3 Priority: low Type:FutureRelease Not relevant to currently planned releases/milestones
Projects
None yet
Development

No branches or pull requests

4 participants