Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[silicon_creator/sw] refactor the otbn_boot_attestation_keygen function #22622

Closed
timothytrippel opened this issue Apr 17, 2024 · 0 comments · Fixed by #22810
Closed

[silicon_creator/sw] refactor the otbn_boot_attestation_keygen function #22622

timothytrippel opened this issue Apr 17, 2024 · 0 comments · Fixed by #22810
Assignees
@timothytrippel
Labels
Component:Software Issue related to Software Manufacturing Issues related to manufacturing tasks (hw or sw) Priority:P1 Priority: high SW:ROM_EXT ROM_EXT related issues Type:Task Tasks, to-do list.
Milestone
Earlgrey-PROD.ROM

Comments

@timothytrippel
Copy link
Contributor

timothytrippel commented Apr 17, 2024 •
edited
Loading

To enable #22573, we need to refactor the otbn_boot_attestation_keygen function to: allow selecting which side of the key ladder we are generating a key from. For the TPM key case we want to generate from the sealing side, but as is currently written, the otbn_boot_attestation_keygen function calls sc_keymgr_generate_attestation_key_otbn here, which under the hood, selects the attestation side of the key ladder here.

Originally posted by @timothytrippel in #22573 (comment)
@timothytrippel timothytrippel added SW:ROM_EXT ROM_EXT related issues Manufacturing Issues related to manufacturing tasks (hw or sw) Component:Software Issue related to Software Priority:P1 Priority: high Type:Task Tasks, to-do list. labels Apr 17, 2024
@timothytrippel timothytrippel added this to the Earlgrey-PROD.ROM milestone Apr 17, 2024
@timothytrippel timothytrippel changed the title We will need to refactor the otbn_boot_attestation_keygen function to: [silicon_creator/sw] refactor the otbn_boot_attestation_keygen function to: Apr 17, 2024
@timothytrippel timothytrippel mentioned this issue Apr 17, 2024
Merged
@timothytrippel timothytrippel changed the title [silicon_creator/sw] refactor the otbn_boot_attestation_keygen function to: [silicon_creator/sw] refactor the otbn_boot_attestation_keygen function to Apr 17, 2024
@timothytrippel timothytrippel changed the title [silicon_creator/sw] refactor the otbn_boot_attestation_keygen function to [silicon_creator/sw] refactor the otbn_boot_attestation_keygen function Apr 17, 2024
@timothytrippel timothytrippel self-assigned this Apr 22, 2024
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 24, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
a23b6e1 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 24, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
70a2cce 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
@timothytrippel timothytrippel mentioned this issue Apr 24, 2024
Merged
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 25, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
bda5118 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 27, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
e6e0822 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 29, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
f3edc3e 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
timothytrippel added a commit that referenced this issue Apr 30, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
641d4e0 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes #22622.

Signed-off-by: Tim Trippel <[email protected]>
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue Apr 30, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
e1a7425 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
(cherry picked from commit 641d4e0)
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue May 1, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
a2b9e4d 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
(cherry picked from commit 641d4e0)
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue May 3, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
5c15829 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
(cherry picked from commit 641d4e0)
timothytrippel added a commit to timothytrippel/opentitan that referenced this issue May 3, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
cc55e19 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes lowRISC#22622.

Signed-off-by: Tim Trippel <[email protected]>
(cherry picked from commit 641d4e0)
timothytrippel added a commit that referenced this issue May 4, 2024
@timothytrippel
[sw/silicon_creator] enable OTBN boot services to gen TPM keys
6c45e24 
This refactors the OTBN boot services library, and silicon_creator
keymgr driver to enable generating two types attestation keys:
1. DICE keys, that are based on the attestation side of the key ladder,
   and
2. TPM keys, that are based on the sealing side of the key ladder.

This fixes #22622.

Signed-off-by: Tim Trippel <[email protected]>
(cherry picked from commit 641d4e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothytrippel timothytrippel

Labels
Component:Software Issue related to Software Manufacturing Issues related to manufacturing tasks (hw or sw) Priority:P1 Priority: high SW:ROM_EXT ROM_EXT related issues Type:Task Tasks, to-do list.
Projects
None yet
Milestone
Earlgrey-PROD.ROM
1 participant
@timothytrippel