Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entropy_src] Outline potential hardware changes for ECDSA sigverify in ROM #21652

Closed
vogelpi opened this issue Feb 23, 2024 · 3 comments
Closed
Assignees
Labels
Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Subsystem:Entropy entropy_src, csrng, or edn related issues

Comments

@vogelpi
Copy link
Contributor

vogelpi commented Feb 23, 2024

Description

As @h-filali is working his way through the entropy_src hardware changes required for Earlgrey-PROD.M2, we were wondering if there are any hardware changes needed for ECDSA signature verification in ROM.

For example, in the current version of the ROM, the entropy_src is first setup in boot mode in which only a single seed can be generated. This is sufficient to instantiate one CSRNG instance / one EDN. But not for running OTBN code consuming entropy from both EDN interfaces (URND, RND).

@moidx , @cfrantz , @johannheyszl , @msfschaffner, @timothytrippel

@vogelpi vogelpi added Subsystem:Entropy entropy_src, csrng, or edn related issues IP:entropy_src labels Feb 23, 2024
@vogelpi vogelpi added this to the Earlgrey-PROD.M2 milestone Feb 23, 2024
@moidx
Copy link
Contributor

moidx commented Feb 23, 2024

Hi @vogelpi, I think it is worth considering to add support to initialize all EDN instances as a backup option, and potentially even one additional seed for CSRNG SW channel. It is too early for us to know the priority for this, but it is a good idea to get a high level estimate.

@h-filali h-filali added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Feb 26, 2024
@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 27, 2024

Thanks for your feedback @moidx . I thought a bit more about this and also discussed with @h-filali and @johannheyszl .

IIUC, we would need probably need FIPS quality entropy for this. And maybe it's only needed once per new ROM ext, so for these one off cases, one could boot the entropy src into FIPS mode. But discussions are still ongoing. We'll likely discuss this weeks Sec WG.

Independent of such discussions, changing the hardware design to produce 3 seeds in boot mode should be doable without area overhead / timing impact. If we conclude that we really need that, we can add this also after M2. To not forget about this, I am moving this issue to M3 for now.

@andreaskurth
Copy link
Contributor

@moidx: No longer an issue because ROM space is limited.

@andreaskurth andreaskurth closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:entropy_src Subsystem:Entropy entropy_src, csrng, or edn related issues
Projects
None yet
Development

No branches or pull requests

4 participants