Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device] Optimize CS pin on at most 1-2 pinmux paths #21538

Closed
moidx opened this issue Feb 17, 2024 · 6 comments · Fixed by #21595
Closed

[spi_device] Optimize CS pin on at most 1-2 pinmux paths #21538

moidx opened this issue Feb 17, 2024 · 6 comments · Fixed by #21595
Assignees

Comments

@moidx
Copy link
Contributor

moidx commented Feb 17, 2024

Description

The current timing constraints for SPI TPM CS try to optimize timing against all muxable IO configurations. This causes timing convergence issues, and we won't be able to support this in the silicon PROD iteration.

Silicon integrations should be constrained to using 1 or 2 pin mapping locations for the TPM CS signal.

@brendose is it ok to define a constraint for this on the integration pinouts? If so, can you provide feedback on which pins to use? It would be ideal if this also falls in the outer ring of the package in case we have to support a single package for multiple use cases.

CC: @msfschaffner, @a-will

@moidx moidx added this to the Earlgrey-PROD.M2 milestone Feb 17, 2024
@moidx moidx self-assigned this Feb 17, 2024
@moidx
Copy link
Contributor Author

moidx commented Feb 17, 2024

We'll also have to update the top-level documentation to capture this.

@moidx
Copy link
Contributor Author

moidx commented Feb 21, 2024

Let's allocate IOA2 for TPM CS.

@brendose is confirming this with @jesultra.

@jettr
Copy link
Contributor

jettr commented Feb 21, 2024

We are currently using IOA7 for SPI_CSB, can we use that instead of IOA2

@moidx
Copy link
Contributor Author

moidx commented Feb 21, 2024

We are currently using IOA7 for SPI_CSB, can we use that instead of IOA2

Yes, we can use IOA7 instead. If there are no objections we can close this issue once the SDC file constraints are updated to use this pin.

Thanks everyone!

@brendose
Copy link

No objections from hardware side. IOA7 is suitable.

@jesultra
Copy link
Contributor

As Jett said, IOA7 is the pin that ChromeOS planned to use for SPI TPM CS, and if the hardware can support only one pin, that should be it. If the hardware could support limited mux'ing between two pins, then we would want to be able to select either IOA7 or IOA2. The latter would help in a hypothetical future scenario, in which the OT chip would simultaneously support I2C (on IOA7/8) and SPI TPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants