Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device,dv] Add assertion to test SRAM logic is faster than update of current_address_i. #18352

Open
hcallahan-lowrisc opened this issue May 5, 2023 · 2 comments
Assignees
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low Type:Icebox Changes deferred to future milestones

Comments

@hcallahan-lowrisc
Copy link
Contributor

hcallahan-lowrisc commented May 5, 2023

Description

StActive: begin
// Assume the SRAM logic is faster than update of current_address_i.
// TODO: Put assertion.
addr_sel = AddrContinuous; // Pointing to next_address to check mailbox hit

@hcallahan-lowrisc hcallahan-lowrisc added Component:DV DV issue: testbench, test case, etc. IP:spi_device Type:Icebox Changes deferred to future milestones labels May 5, 2023
@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 7, 2023
@msfschaffner msfschaffner added this to the Earlgrey-PROD.M4 milestone Nov 7, 2023
@msfschaffner msfschaffner added the Priority:P2 Priority: medium label Dec 4, 2023
@johngt johngt added Priority:P3 Priority: low and removed Priority:P2 Priority: medium labels Jun 11, 2024
@moidx
Copy link
Contributor

moidx commented Jun 20, 2024

@antmarzam, @hcallahan-lowrisc, if the design assumption is not correct, we expect to see failures at block and top level as long as we are randomizing the contents of SRAM (per address). Can you take a look and move to M7 if this is the case?

AI: Check for pre-existing GitHub issues to see if this is covered elsewhere.

@andreaskurth
Copy link
Contributor

Quoting @hcallahan-lowrisc (out of band communication):

we discussed in the review meeting that if this condition was not true then there would be wide breakage across the whole project. As such, decided that low priority/ M7 is fine.

Just discussed in issue triage that we agree and hence move this to M7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low Type:Icebox Changes deferred to future milestones
Projects
None yet
Development

No branches or pull requests

6 participants