Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script/alert_handler] generated files maintain a stable API #17755

Closed
cindychip opened this issue Mar 29, 2023 · 0 comments
Closed

[script/alert_handler] generated files maintain a stable API #17755

cindychip opened this issue Mar 29, 2023 · 0 comments
Assignees
@msfschaffner
Labels
Priority:P4 Priority: propose to move to backlog Type:Question Questions
Milestone
Earlgrey ES M2.5....

Comments

@cindychip
Copy link
Contributor

cindychip commented Mar 29, 2023 •
edited
Loading

Description

From alert_handler_reg_core.tpl, there is a TODO to check:
Check if the generated files actually maintain a stable public API.

Looks like the ip_autogen folder under top_earlgrey is very stable, so I removed the TODO from PR #17756
to sign off D2.5. But wanted to file this issue to double check.
@cindychip cindychip added Type:Question Questions Priority:P4 Priority: propose to move to backlog labels Mar 29, 2023
@cindychip cindychip added this to the Discrete: M2.5 milestone Mar 29, 2023
cindychip added a commit to cindychip/opentitan that referenced this issue Mar 29, 2023
@cindychip
[alert_handler] remove alert_handler todos
cb4f2aa 
Remove three todos from alert_handler:
1). Testbench todo: uncomment and remove the temp code.
2). CSR exclusion - I removed the todo and filed an issue lowRISC#17754.
3). I think this is stale TODO, but filed an issue lowRISC#17755 to check with
  msf.

Signed-off-by: Cindy Chen <[email protected]>
@cindychip cindychip mentioned this issue Mar 29, 2023
Merged
cindychip added a commit that referenced this issue Mar 29, 2023
@cindychip
[alert_handler] remove alert_handler todos
ae9b562 
Remove three todos from alert_handler:
1). Testbench todo: uncomment and remove the temp code.
2). CSR exclusion - I removed the todo and filed an issue #17754.
3). I think this is stale TODO, but filed an issue #17755 to check with
  msf.

Signed-off-by: Cindy Chen <[email protected]>
@andreaskurth andreaskurth mentioned this issue Feb 22, 2024
Closed
@msfschaffner msfschaffner mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msfschaffner msfschaffner

Labels
Priority:P4 Priority: propose to move to backlog Type:Question Questions
Projects
None yet
Milestone
Earlgrey ES M2.5.Backlog
Development

No branches or pull requests
2 participants
@cindychip @msfschaffner