Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device] Add an enable/active CSR #14717

Closed
weicaiyang opened this issue Sep 1, 2022 · 3 comments
Closed

[spi_device] Add an enable/active CSR #14717

weicaiyang opened this issue Sep 1, 2022 · 3 comments
Assignees
Labels
Hotlist:Silicon to be resolved in Silicon Committee
Milestone

Comments

@weicaiyang
Copy link
Contributor

@eunchan

As @a-will suggested, we could add an enable/active CSR. When it's off, spi_device is in reset state and it stops the cmd parser and passthrough path, so that any incoming SPI transaction will be ignored.
SW can turn it on after finishing the spi_device configuration.

@eunchan
Copy link
Contributor

eunchan commented Sep 6, 2022

related (or duplicated) #14665

@eunchan
Copy link
Contributor

eunchan commented Sep 6, 2022

CDC may be a concern. EN in CSR needs to be propagated to SPI correctly.

I think more safer approach is to block SPI CLK until configuration is done as suggested in #9503 .

If not, I don't know how I can hand over the en signal to SPI_CLK domain safely and not lose the first SPI transaction.

CC: @tjaychen @a-will

@msfschaffner msfschaffner added this to the Project: M2 milestone Sep 30, 2022
@weicaiyang
Copy link
Contributor Author

closing as duplicated of #14665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hotlist:Silicon to be resolved in Silicon Committee
Projects
None yet
Development

No branches or pull requests

4 participants