[sram_ctrl] D3 review opens

[msfschaffner]

• Review tlul_adapater_sram parameters (msf / tim) [sram_ctrl] Consider refactoring tlul_adapter_sram #7462, [sram_ctrl] Enable secure FIFO counters #13771
• Style nit: sram_ctrl.sv: 146, input port with direct logic expression instead put combinational logic elsewhere with a new signal name to feed into the input port [sram_ctrl] Minor style cleanup #13677
• Style nit: sram_ctrl.sv: 187: Enclose unary OR in parentheses (more import when change to bitwise OR from above it applied) [sram_ctrl] Minor style cleanup #13677
• Style nit: Sram_ctrl.sv: 179, 185: Use of || logic OR where style guide states bitwise | OR should be used. [sram_ctrl] Minor style cleanup #13677
• Doc: the programmer’s guide should probably recommend spinning on STATUS.SCR_KEY_VALID when requesting a new key, since the PC value on a watchdog crash will likely be the only clue about what happened if it makes no progress (if someone forgets to initialize the CSRNG and EDN). [sram_ctrl] Minor style cleanup #13677
• Review rom for usage of sram clearing / init: main sram and retention sram

[a-will]

The ROM chooses to block on the SRAM accesses instead of checking STATUS.SCR_KEY_VALID. This is okay, since we know for sure that we set up the CSRNG and EDN before changing keys. It's a recommendation for more debuggable user code, not a "should" or "must" ;)

[msfschaffner]

Cool, thanks for checking.