Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API support #4

Open
NickNaso opened this issue Mar 31, 2018 · 2 comments
Open

N-API support #4

NickNaso opened this issue Mar 31, 2018 · 2 comments

Comments

@NickNaso
Copy link

NickNaso commented Mar 31, 2018

Hi @lovell ,
I worked on this native addon and I ported it to N-API
You can find my work here: https://github.com/NickNaso/64/tree/napi
If you want experiment with N-API you can create a branch and call it "napi" so I can execute the PR on it.
After that we can iterate to over it and at the end publish a tagged version of 64 like reported here: https://nodejs.org/en/docs/guides/publishing-napi-modules/

@lovell
Copy link
Owner

lovell commented Apr 3, 2018

Hello again, thanks for this Nick, like with your similar improvements for farmhash at lovell/farmhash#19 we can merge this when prebuild supports N-API too.

@NickNaso
Copy link
Author

NickNaso commented Oct 8, 2018

Hi @lovell I want only notify that last week prebuild added the support for N-API https://www.npmjs.com/package/prebuild#n-api-considerations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants