-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "ru" language on Safari #2843
Comments
I just looked a bit through the locale file names and there is indeed no clear naming convention followed here for this… Some are in format “language_Territory” some are not. With regards to language Wwe should follow one standard - ideally one that is most compatible… Is this issue for the Russian language isolated to this one only or for others as well? |
I think it is enough to rename all locales to a two-letter format, because the first two letters denote the language and the rest is the dialect. It's not that important, most likely. For the Russian language, that's for sure. Here are examples of locales |
Currently, it depends on a single variable Line 58 in a80f228
I think it should be handled in code like: if navigator.language == "ru", then current language = "ru-RU" Or change to use
I checked on Weblate, they do provide both formats, I think it is part of ISO standards.
Incorrect for |
Why not rename lang file ru-RU to ru and change key in array to ru ? Judging by this code, both ru and ru-RU will be processed in the end |
#4244 was merged into the |
🛡️ Security Policy
Description
In safari the locale is defined as "ru", but in Chrome it is "ru-RU".
Because of this on the status pages in safari the inscriptions are in English.
If you rename file src/lang/ru-RU.json to src/lang/ru.json, this language will be connected in both Chrome and Safari.
and change languageList key in /src/i18n.js from "ru-RU" to "ru"
👟 Reproduction steps
create status page. open page in safari
👀 Expected behavior
title from ru file "Все системы работают в штатном режиме"
😓 Actual Behavior
title from en file "All Systems Operational"
🐻 Uptime-Kuma Version
1.20.1
💻 Operating System and Arch
ubuntu
🌐 Browser
Safari 16.3
🐋 Docker Version
No response
🟩 NodeJS Version
No response
📝 Relevant log output
No response
The text was updated successfully, but these errors were encountered: