Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/pkgset: avoid loading all std packages #65

Open
egonelbre opened this issue Oct 12, 2022 · 0 comments
Open

internal/pkgset: avoid loading all std packages #65

egonelbre opened this issue Oct 12, 2022 · 0 comments

Comments

@egonelbre
Copy link
Member

Currently the code loads all the std library packages, which takes a bunch of time. It's only used to remove std library packages from the output.

https://github.com/loov/goda/blob/v0.5.3/internal/pkgset/std.go#L13

Instead of loading the std packages separately, write a func that detects based on packages.Package whether it's a std library package or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egonelbre