Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OpenTelemetry #392

Open
janiskemper opened this issue Sep 12, 2022 · 5 comments
Open

Switch to OpenTelemetry #392

janiskemper opened this issue Sep 12, 2022 · 5 comments

Comments

@janiskemper
Copy link

Is your feature request related to a problem? Please describe.
OpenTracing is deprecated in favor of OpenTelemetry (opentracing/specification#163)

Describe the solution you'd like
Switch to OpenTelemetry.

@marcwickenden
Copy link
Contributor

marcwickenden commented Sep 12, 2022

I have this (kinda) working on my fork at https://github.com/marcwickenden/eventhorizon/tree/opentelemetry. I haven't submitted a PR because it's not fully tested yet (not sure if propagation is reliable) and I've also implemented it in a way that is not backwards compatible with the existing version. Might be useful though?

@janiskemper
Copy link
Author

Thanks a lot @marcwickenden ! That will help me getting started 👍

@maxekman
Copy link
Member

maxekman commented Oct 1, 2022

Great idea! I would be glad to accept a PR!

@maxekman maxekman added enhancement core Core components and removed core Core components labels Oct 1, 2022
@jefflinse
Copy link
Contributor

Hey @janiskemper, just curious if you've made any progress on this or would like help? Would be great to see OTEL support in EventHorizon.

@janiskemper
Copy link
Author

Hey, yes I actually worked on it and did make some progress, but never reached the state that it would be possible to make a PR in this project.

I stopped working on it eventually because I realized that my use case was not fully covered by this project. Therefore, I shifted my work a bit away. Currently, I am focusing on very different topics, so I won't be able to continue with this. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants