Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike][User] Refactor password implementation #7

Closed
1 task
virkt25 opened this issue Sep 4, 2018 · 1 comment
Closed
1 task

[Spike][User] Refactor password implementation #7

virkt25 opened this issue Sep 4, 2018 · 1 comment

Comments

@virkt25
Copy link
Contributor

virkt25 commented Sep 4, 2018

From #5 (comment)

While this is good enough for the initial implementation, it is also very brittle. We should find a more robust way how to allow models to hide certain properties from toJSON output.

In the past, I had very good experience with moving the password to a different model (table/collection) and use hasMany relation. As a nice side effect, by keeping a hash of all previous passwords, we can easily implement a password policy like "cannot reuse the same password".


I think this needs some discussion as I'm personally not sure if refactoring passwords to it's own table is the best design but agree current design is a bit brittle.

Let's discuss this issue and refine the acceptance criteria.

Acceptance Criteria

  • Explore a more secure and robust way to store the password for users
    • As suggested above, we can try store Password in a separate model(table/collection)
    • Feel free to come up with other solutions.
@jannyHou jannyHou changed the title [User] Refactor password implementation [Spike][User] Refactor password implementation Sep 20, 2019
@dhmlau
Copy link
Member

dhmlau commented Dec 19, 2019

Closing due to inactivity. Authentication has changed quite a bit in the past year.

@dhmlau dhmlau closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants