Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from strong-docs to TypeDoc for generating API documentation #989

Closed
kjdelisle opened this issue Feb 13, 2018 · 6 comments
Closed

Comments

@kjdelisle
Copy link
Contributor

kjdelisle commented Feb 13, 2018

connected to #874
related to #584

Overview

Determine the work required to migrate from strong-docs to TypeDoc as our default API documentation generator for LoopBack 4.

NOTE: These questions must be answered for the spike to be considered complete, since they determine:

  • Whether or not we can use TypeDoc
  • What sort of effort is required to switch to using it
  • Whether or not the cost/benefit of doing so is not as attractive as fixing strong-docs to correctly use TypeDoc

Questions To Answer

  • How will the generated TypeDoc be incorporated into our website? (Do we need to do something differently to have these docs appear on apidocs.strongloop.com?)
    • How does the current API document deployment work with strong-docs?
    • Can we simply drop in the new generated docs site as a replacement?
  • Can we change the layout of the generated documentation made by TypeDoc?
    • If so, which parts are easily changed and which are not?
    • List the steps required to make these layout changes
  • Can we change the theme of the generated documentation and site links (to fit our current/future site aesthetics)?
    • What are the steps that need to be taken to do this?
  • Are there any gaps in the generated documentation with TypeDoc?
    • If so, list them as well as the impact this may have on areas of the documentation
  • What license does TypeDoc use?
    • The default template adds a created-by message and link at the bottom of all generated pages; does the license require that we keep this?
    • Are there any other requirements to use TypeDoc?
  • Can we modify the output of TypeDoc programmatically?
    • If so, what options are available to us?
@dhmlau
Copy link
Member

dhmlau commented Feb 13, 2018

As part of the spike, can we also find out if the problem in #584 will be gone too?

@raymondfeng
Copy link
Contributor

FYI: strong-docs internally uses typedoc programatically. It parses docs.json and passes the file names to typedoc to create metadata constructs for TypeScript.

@raymondfeng
Copy link
Contributor

I think #874 has been fixed. With that, I don't see the need to switch.

@dhmlau
Copy link
Member

dhmlau commented Feb 23, 2018

@kjdelisle , could you please take a look if we still need to do this spike, based on @raymondfeng 's comments?

@dhmlau
Copy link
Member

dhmlau commented Mar 11, 2018

@kjdelisle ^^^

@virkt25
Copy link
Contributor

virkt25 commented Mar 12, 2018

Closing this as no longer needed. Majority of outstanding issues have been fixed by @raymondfeng via #874

@virkt25 virkt25 closed this as completed Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants