-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in tests for JSON Schemas being produced #971
Comments
A list of packages we can use for validation: |
How is this different from #1294? |
@virkt25 #1294 is adding in validation for the purpose of validating parameters parsed from http requests. This one will be used to validate whether the JSON Schemas our packages produce are themselves valid JSON Schemas. The reason we should have this validation should be congruent to the reason we have openapi-v3 spec validator. |
Throwing back to have the acceptance criteria fleshed out: what is this extension geared towards? What is the UX? Is this an internal utility? If internal: it should live in testlab, it should also be less restrictive |
Returning a boolean is not helpful. When the document is not a valid JSON schema, then we need a descriptive list of spec violations, so that we know what to fix!
To be honest, I don't know. What was your intention when you opened this issue? As I am thinking about this, maybe what we really want is to write few unit tests for |
repository-json-schema
should be validated against this meta-schema (used to validate the schema itself): http://json-schema.org/schema. More information here: http://json-schema.org/specification.html#meta-schemas.Acceptance Criteria
repository-json-schema
repository-json-schema
with a JSON-Schema-validating-JSON SchemaThe text was updated successfully, but these errors were encountered: