Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Juggler] Spike: EventEmitters in the new world of async/await #898

Closed
bajtos opened this issue Jan 23, 2018 · 7 comments
Closed

[Juggler] Spike: EventEmitters in the new world of async/await #898

bajtos opened this issue Jan 23, 2018 · 7 comments

Comments

@bajtos
Copy link
Member

bajtos commented Jan 23, 2018

What to do with EventEmitters (Observables?) after all other callback-based APIs were upgraded to Promises and async/await via #896?

See also #537 (comment)

@raymondfeng
Copy link
Contributor

raymondfeng commented Jan 25, 2018

@bajtos I had a similar PoC at https://github.com/strongloop/loopback-next/blob/008b3fd081f39f0055ea5e16c5124a84a07a688d/packages/core/src/sequence.ts#L96. We can refactor the core async publish/subscribe logic into its own.

@kjdelisle
Copy link
Contributor

@raymondfeng Would it make sense to incorporate an existing framework like RxJs instead of building that ourselves?

@raymondfeng
Copy link
Contributor

RxJs seems to be fairly complicated at least for the number of APIs. We can align it with https://github.com/tc39/proposal-observable.

@kjdelisle
Copy link
Contributor

@raymondfeng The proposal link has zen-observable as well, and it seems more straightforward than RxJS. Would that be any better, or are we planning to make something that maps strictly to the proposal with no extras?

@raymondfeng
Copy link
Contributor

We can pick a reasonable module to start with and see if it fits our needs. I won't ask for compliance.

@stale
Copy link

stale bot commented Sep 17, 2019

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Sep 17, 2019
@stale
Copy link

stale bot commented Oct 17, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants