Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSSC-GVT]English String when input command apic lb4 app -h #5654

Closed
2 tasks
wxuwh opened this issue Jun 4, 2020 · 7 comments
Closed
2 tasks

[GSSC-GVT]English String when input command apic lb4 app -h #5654

wxuwh opened this issue Jun 4, 2020 · 7 comments
Assignees
Labels
bug GVT For translation tests
Milestone

Comments

@wxuwh
Copy link

wxuwh commented Jun 4, 2020

27.030.010 APIC apic lb4 app -h (Apr)

Steps & Verification Points:
input ./apic lb4 app -h
and click Enter
Verify the strings in red circle.

Actual Result:
image

Acceptance Criteria

  • Investigate if we can externalize the highlighted string
  • If possible, externalize it
@wxuwh wxuwh added the bug label Jun 4, 2020
@dougal83 dougal83 added the GVT For translation tests label Jun 4, 2020
@dhmlau dhmlau added the 2020Q3 label Jun 5, 2020
@dhmlau dhmlau added this to the Jul 2020 milestone Jun 16, 2020
@agnes512 agnes512 self-assigned this Jul 8, 2020
@agnes512
Copy link
Contributor

agnes512 commented Jul 8, 2020

image

It seems to be translated correctly. I am not able to reproduce the issue.

@dhmlau
Copy link
Member

dhmlau commented Jul 8, 2020

Thanks for checking @agnes512. I saw that phrase was recently added to the messages.json.

@dhmlau
Copy link
Member

dhmlau commented Jul 8, 2020

Closing as done.

@dhmlau dhmlau closed this as completed Jul 8, 2020
@candytangnb
Copy link
Contributor

@agnes512 in the screen you provided there is another English string.
image

I update my loopback/cli to 2.12.0 and still in English
image

@agnes512 agnes512 reopened this Aug 13, 2020
@agnes512
Copy link
Contributor

You're right, I didn’t notice the --ask-answered is in English. I only checked packageManager. Let me reopened the issue

@agnes512
Copy link
Contributor

Checked, I think --ask--answered is translated
截圖 2020-08-13 上午9 54 30

@candytangnb
Copy link
Contributor

works well on loopback@cli 2.13.0
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GVT For translation tests
Projects
None yet
Development

No branches or pull requests

5 participants