Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(model-api-builder) Peer dependencies out of date? #4889

Closed
dougal83 opened this issue Mar 14, 2020 · 5 comments
Closed

(model-api-builder) Peer dependencies out of date? #4889

dougal83 opened this issue Mar 14, 2020 · 5 comments
Assignees

Comments

@dougal83
Copy link
Contributor

Should these dependencies be ^.2.0.0?

https://github.com/strongloop/loopback-next/blob/4a25fa25ce33129f52b0e6eb196d2100c55ccb6e/packages/model-api-builder/package.json#L22-L25

@raymondfeng
Copy link
Contributor

Lerna decided to not update peerDependencies as part of lerna version. See lerna/lerna#1575.

I'm not a big fan of peerDependencies. I think we should either improve https://github.com/strongloop/loopback-next/blob/master/bin/update-template-deps.js to update peerDependencies or move them to regular dependencies.

@bajtos might have a different opinion.

@dougal83
Copy link
Contributor Author

I was just looking at yarn and it came up when installing deps. Any thoughts on optional-deps while we're on the subject? fsevents & nan might be candidates for consideration.

@raymondfeng
Copy link
Contributor

I don’t think we use optional deps for @loopback/ modules, do we?

I would only declare non-critical binary addons as optional dep.

@dougal83
Copy link
Contributor Author

dougal83 commented Mar 14, 2020

I don’t think we use optional deps for @loopback/ modules, do we?

Not that I can see. Yarn discourages use of implicit dependencies like fsevents (< rimraf < lbclean). Declaring as optional deps seems like an option. Or not 😄

@dougal83
Copy link
Contributor Author

dougal83 commented Apr 7, 2020

Closed by #4972

@dougal83 dougal83 closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants