Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] How to migrate Angular 1.x and 2+ LB3 client #4610

Closed
3 tasks
dhmlau opened this issue Feb 10, 2020 · 8 comments
Closed
3 tasks

[Spike] How to migrate Angular 1.x and 2+ LB3 client #4610

dhmlau opened this issue Feb 10, 2020 · 8 comments

Comments

@dhmlau
Copy link
Member

dhmlau commented Feb 10, 2020

Originated from epic: #3954

A spike on migrating Angular 1.x and 2+ LB3 client.

Acceptance Criteria

  • Find out whether OpenAPI generator a good solution
    • If yes, how to migrate?
    • If no, what would be our recommended solution in the context of migration guide?
  • Expected outcome:
    • our recommended approach and description on how to do it.
    • create a follow up task, if needed, to add the instruction as part of the migration guide
@derdeka
Copy link
Contributor

derdeka commented Feb 11, 2020

@dhmlau I did POCs for OpenAPI generator and ng-openapi-gen in the last weeks and can share some stuff. Both of them have their upsides and downsides, but are very different to loopback-sdk-builder. My hope was to find a kind of drop-in-replacement for loopback-sdk-builder to limit the required refactorings to my frontend application to a minimum in the first step, but both of them need big changes.

How do you want to run the spike? I suggest to create two alternative frontends for loopback4-example-shopping to test both sdks. How to start?

@dhmlau
Copy link
Member Author

dhmlau commented Feb 11, 2020

@derdeka, it would be great if you could share the information between OpenAPI generator and ng-openapi-gen. Thanks!

I just discussed with @bajtos, it might be good to:

  • take the CoffeeShop application as the starting point - it's a smaller app than the shopping app
  • generate the client using LB3 SDK client and OpenAPI generator (or ng-openapi-gen).
  • compare the differences
    WDYT?

Also, we're not sure if we should only investigate the Angular 2+ client route, perhaps there are much fewer users on Angular 1.x?

@derdeka
Copy link
Contributor

derdeka commented Feb 17, 2020

@dhmlau AFAIK there is no coffeeshop app written in lb4 yet. Correct?

@dhmlau
Copy link
Member Author

dhmlau commented Mar 17, 2020

@derdeka, I'm so sorry that I missed your message. There is no specific CoffeeShop example yet, however, I just created a validation example #4895 which uses a CoffeeShop model.

@dhmlau
Copy link
Member Author

dhmlau commented Mar 17, 2020

Also, the LB4 app in #4895 (validation example) won't have model relations.

@dhmlau
Copy link
Member Author

dhmlau commented Apr 21, 2020

From our last maintainers call, @derdeka mentioned that the client generated by the client generators he looked at are not quite similar to the one generated by LB3 Angular SDK.

@raymondfeng @derdeka, could you please fill us in on the approach suggested by @raymondfeng? Would like to see how we can move forward with this. Thanks!

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Dec 25, 2020
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants