-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): refactoring common filter schemas #4328
Comments
@bajtos Here is a draft gist. I need to run code against samples and write tests(*sigh). Where would be the best to place this code and where to inject it's functionality? I'll put into PR for review pending your feedback. |
@dougal83 commented in #4290 (comment) :) |
After we land feat(rest): add openapi schema consolidation #4365, I'd like to start the process of deprecating
Considering the scope of that work, I think it may be better to open a follow-up issue. Thoughts? |
Closing as done. Opened #5791 as follow up issue. |
Related: #4290 (comment)
Currently, the filter schemas are generated inline in the OAS
openapi.json
document. This may lead to the filter schemas being repeated within the same OAS docs.Suggestion
Instead, these schemas should be refactored into
/components/schemas
.Use Cases
The OAS document may be more compact and have increased readability as the filter schemas will not be repeated. Furthermore, the generated client-side code may also benefit similarly.
Examples
(Taken from: #4290 (comment))
Acceptance criteria
TBD - will be filled by the team.
The text was updated successfully, but these errors were encountered: